Change in coreboot[master]: cpu/x86/64bit: Generate static page tables from an assembly file - coreboot-gerrit

21 Apr 2022


      Attention is currently required from: Raul Rangel, Patrick Rudolph, Angel Pons, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63725 )
Change subject: cpu/x86/64bit: Generate static page tables from an assembly file
......................................................................
Patch Set 4:
(2 comments)
File src/cpu/x86/64bit/pt.S:
https://review.coreboot.org/c/coreboot/+/63725/comment/e3af7b82_96a2dddc 
PS3, Line 4: ArchitectureProgrammer
...
nit: missing a space
Done
File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63725/comment/65cd0f68_4e50357c 
PS3, Line 7: CONFIG_ARCH_BOOTBLOCK_X86_64
...
...
I guess I'm concerned about the PSP Verstage case. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e31b701a2584268c85d327bf139953213899e3
Gerrit-Change-Number: 63725
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 21 Apr 2022 10:02:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment