Change in coreboot[master]: utils/docker/coreboot-sdk: Update python to python2, add python3

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Martin Roth (Code Review)

10 Sep 2020 10 Sep '20

12:06 p.m.

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

utils/docker/coreboot-sdk: Update python to python2, add python3

The latest debian image needs the python2 package specified instead of just 'python'. Also add python3 to the builder as we'll probably be getting python3 scripts before too long.

Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Signed-off-by: Martin Roth gaumless@gmail.com --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/45265/1

diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 7c87056..007e9af 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -63,7 +63,8 @@ openssl \ patch \ pkg-config \ - python \ + python2 \ + python3 \ qemu \ rsync \ shellcheck \

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Martin Roth (Code Review)

10 Sep 10 Sep

12:08 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

Patch Set 1:

Getting ready to update the builders. The python->python2 change is required. I thought I'd add python3 as well, but that's not a requirement for this update and can be removed if requested.

Paul Menzel (Code Review)

12:45 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45265/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45265/1//COMMIT_MSG@7 PS1, Line 7: utils/docker/coreboot-sdk: Update python to python2, add python3 I thought everything in coreboot was converted to Python 3?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Gerrit-Change-Number: 45265 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 15:45:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:51 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45265/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45265/1//COMMIT_MSG@7 PS1, Line 7: utils/docker/coreboot-sdk: Update python to python2, add python3

...

I thought everything in coreboot was converted to Python 3?

It's possible to write python code that is capable of running with both, and I think that's where we are. It's needlessly complicated though.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Gerrit-Change-Number: 45265 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 15:51:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:51 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Gerrit-Change-Number: 45265 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 15:51:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

12 Sep 12 Sep

1:18 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

Patch Set 1:

If someone will merge this, I'll update the builders. Thanks!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Gerrit-Change-Number: 45265 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 12 Sep 2020 16:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

David Hendricks (Code Review)

13 Sep 13 Sep

8:14 p.m.

David Hendricks has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

utils/docker/coreboot-sdk: Update python to python2, add python3

The latest debian image needs the python2 package specified instead of just 'python'. Also add python3 to the builder as we'll probably be getting python3 scripts before too long.

Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Signed-off-by: Martin Roth gaumless@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45265 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/45265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Gerrit-Change-Number: 45265 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

David Hendricks (Code Review)

8:14 p.m.

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45265 )

Change subject: utils/docker/coreboot-sdk: Update python to python2, add python3 ......................................................................

Patch Set 2:

...

Patch Set 1:

If someone will merge this, I'll update the builders. Thanks!

Done. Thanks, Martin!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceea3981b1e219141bf06ad0b559cdbf1c98b360 Gerrit-Change-Number: 45265 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 13 Sep 2020 23:14:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1358

days inactive

1361

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

David Hendricks (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)