Attention is currently required from: Richard Hughes, Maximilian Brune.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68995 )
Change subject: Documentation/sbom: Add SBOM Documentation ......................................................................
Patch Set 3:
(13 comments)
File Documentation/sbom/sbom.md:
PS3: Please reflow all lines to 72 characters
https://review.coreboot.org/c/coreboot/+/68995/comment/1634e27f_5b4868d5 PS3, Line 2: shipped Maybe "included" or "pulled in", as "shipped" could imply that the coreboot distributes FSP, which we don't.
https://review.coreboot.org/c/coreboot/+/68995/comment/893ae572_465b8dd5 PS3, Line 2: Coreboot coreboot
https://review.coreboot.org/c/coreboot/+/68995/comment/939d579e_b100a2a6 PS3, Line 2: One could for example create a Software that takes a Coreboot Firmware Image as Input and automatically creates a Graph with all Software components the Coreboot Image contains and their relationship to each other Is there a reason why many words like "Software", "Information", "Binary" and others need to be capitalized throughout this file? It seems a bit excessive and makes sentences like this somewhat more difficult/unusual to read.
https://review.coreboot.org/c/coreboot/+/68995/comment/1962b159_6d82e8e2 PS3, Line 2: These I think "This" works better here
https://review.coreboot.org/c/coreboot/+/68995/comment/aa828505_3bac4812 PS3, Line 2: Coreboot coreboot
https://review.coreboot.org/c/coreboot/+/68995/comment/f38a86cd_16b7cae5 PS3, Line 2: would be Maybe "were a"
https://review.coreboot.org/c/coreboot/+/68995/comment/f2847ec1_632a12ea PS3, Line 17: ] Should be ) to match opening (
https://review.coreboot.org/c/coreboot/+/68995/comment/26f396ba_2d04ff8f PS3, Line 18: GENEREATE GENERATE
https://review.coreboot.org/c/coreboot/+/68995/comment/27832420_a714aecf PS3, Line 18: CONFIG_[software-name]_SBOM_GENEREATE This config appears to be CONFIG_SBOM_[software-name]_GENERATE in the actual Kconfigs
https://review.coreboot.org/c/coreboot/+/68995/comment/378ad2a5_1d53244b PS3, Line 19: CONFIG_[software-name]_SBOM_PATH This config appears to be CONFIG_SBOM_[software-name]_PATH, which was also the order used in previous sentences.
https://review.coreboot.org/c/coreboot/+/68995/comment/5b04cf25_5dee020b PS3, Line 22: Just enable the corresponding options in `make menuconfig` Maybe specify under which submenu these are under?
File Documentation/sbom/sbom_generation.png:
PS3: "Gettings Started > coreboot documentation guidelines" in the documentation says that the maximum image width is 700px