Attention is currently required from: Wonkyu Kim, Subrata Banik, Angel Pons, Nick Vaccaro, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62847 )
Change subject: vendorcode/intel/edk2/edk2-stable202111: Use fixed size struct elements
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/vendorcode/intel/edk2/edk2-stable202111/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/62847/comment/37f1a8ff_89db06c0
PS1, Line 147: UINT32
I swear I brought this up to Nate before, that we should use fixed-size elements for ABIs, never ` […]
Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f33db43f7932cf6d165d0c70a0e2922dad00a09
Gerrit-Change-Number: 62847
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Comment-Date: Thu, 17 Mar 2022 18:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment