Attention is currently required from: Jamie Chen, Paul Menzel, Kane Chen, Andrey Petrov, Patrick Rudolph.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56805 )
Change subject: soc/intel/apollolake: change LPDDR4 density define
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/apollolake/meminit.c:
https://review.coreboot.org/c/coreboot/+/56805/comment/e89b2de1_3776415c
PS1, Line 295: int fsp_rank_density;
Nit: Add an empty line between declaration block and function body.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36dba2cef130211e7aea9e2a4f82c5db78f82a83
Gerrit-Change-Number: 56805
Gerrit-PatchSet: 1
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 11 Aug 2021 00:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment