Attention is currently required from: Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Michał Żygowski, Patrick Rudolph, Tim Chu.
Hello Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Michał Żygowski, Patrick Rudolph, Shuo Liu, Tim Chu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85286?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/xeon_sp: Remove lpc_lockdown_config ......................................................................
soc/intel/xeon_sp: Remove lpc_lockdown_config
If CHIPSET_LOCKDOWN_COREBOOT is selected, lpc_lockdown_config() will be executed in common pch/lockdown firstly. Remove xeon_sp layer lpc_lockdown_config() to avoid duplication. It still could be added back per SoC needs.
The duplicated part are in src/soc/intel/common/pch/lockdown/lockdown.c:
static void platform_lockdown_config(void *unused) { int chipset_lockdown; chipset_lockdown = get_lockdown_config();
/* SPI lock down configuration */ fast_spi_lockdown_cfg(chipset_lockdown);
/* LPC/eSPI lock down configuration */ lpc_lockdown_config(chipset_lockdown);
... }
Change-Id: Ibec389a6d55c7885def6896a0ea435514b75a323 Signed-off-by: Jincheng Li jincheng.li@intel.com --- M src/soc/intel/xeon_sp/lockdown.c 1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85286/2