[L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6373 driver

[Jarried Lin (Code Review)]

Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85129?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIC MT6373 driver
......................................................................

Patch Set 37:

(14 comments)

File src/soc/mediatek/common/include/soc/mt6373.h:

https://review.coreboot.org/c/coreboot/+/85129/comment/40ac7372_80ce6ef3?usp... :
PS33, Line 78: #endif /* __SOC_MEDIATEK_MT6373_H__ */
> Blank line above.

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/99ab1a84_28735ed8?usp... :
PS33, Line 78: #endif /* __SOC_MEDIATEK_MT6373_H__ */
> Blank line above.

Done

File src/soc/mediatek/common/mt6373.c:

https://review.coreboot.org/c/coreboot/+/85129/comment/a589822f_0471b5da?usp... :
PS19, Line 270: 	mt6373_enable_vcn33_3(true);
              : 	mt6373_set_vcn33_3_voltage(3300000);
> Put them in the condition of `if (display_init_required())` in mainboard.c. […]

Ack

File src/soc/mediatek/common/mt6373.c:

https://review.coreboot.org/c/coreboot/+/85129/comment/82a03574_88303aa1?usp... :
PS33, Line 24: u32
> u8

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/99720535_ad01cd9c?usp... :
PS33, Line 46: lock
> Align

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/8141f484_6fab8ee9?usp... :
PS33, Line 56: (
> These parentheses can be removed.

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/d6e79327_6d7da2c5?usp... :
PS33, Line 88: (
> Remove. Same for other similar functions.

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/af4695ea_df53c791?usp... :
PS33, Line 109:
> Extra blank line.

Done

File src/soc/mediatek/common/mt6373.c:

https://review.coreboot.org/c/coreboot/+/85129/comment/e461fcc7_dad64998?usp... :
PS36, Line 23: = NULL
> not needed.

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/879d08d5_484ac7b7?usp... :
PS36, Line 57: )
> remove

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/ade44614_2f57b501?usp... :
PS36, Line 198: 	printk(BIOS_INFO, "%s success\n", __func__);
> Why this message is needed ?

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/581e76e9_d29449bc?usp... :
PS36, Line 229: 0xFFFF
> Is is correct ?

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/5b20e504_0aa79175?usp... :
PS36, Line 247: /* for N project*/
> what does it mean ?

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/5591fc81_5359d394?usp... :
PS36, Line 252: ERROR - Failed to initialize pmif spi
> "%s: initialization failed", __func__

Done