jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48953 )
Change subject: soc/mediatek: dsi: tune the dphy time by eotp enable ......................................................................
soc/mediatek: dsi: tune the dphy time by eotp enable
Eotp will make the line time larger than disable Eotp. So the hfp and hbp should be reduced to keep line time.
BRANCH=kukui BUG=b:168728787 TEST=Boots correctly on Kukui
Signed-off-by: Jitao Shi jitao.shi@mediatek.com Change-Id: I040e4f7fb3ada0a1b2bcf06ea30cf93d98775d6a --- M src/soc/mediatek/common/dsi.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/48953/1
diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi.c index 2505bbc..fca0069 100644 --- a/src/soc/mediatek/common/dsi.c +++ b/src/soc/mediatek/common/dsi.c @@ -202,6 +202,10 @@ phy_timing->da_hs_zero + phy_timing->da_hs_exit + 3;
u32 delta = 12; + + if (!(mode_flags & MIPI_DSI_MODE_EOT_PACKET)) + delta += 2; + if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST) delta += 6;
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Chen-Tsung Hsieh, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48953
to look at the new patch set (#2).
Change subject: soc/mediatek: dsi: tune the dphy time by eotp enable ......................................................................
soc/mediatek: dsi: tune the dphy time by eotp enable
Eotp will make the line time larger than disable Eotp. So the hfp and hbp should be reduced to keep line time.
BRANCH=kukui BUG=b:168728787 TEST=Boots correctly on Kukui
Signed-off-by: Jitao Shi jitao.shi@mediatek.com Change-Id: I040e4f7fb3ada0a1b2bcf06ea30cf93d98775d6a --- M src/soc/mediatek/common/dsi.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/48953/2
Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48953 )
Change subject: soc/mediatek: dsi: tune the dphy time by eotp enable ......................................................................
Patch Set 3:
Hi patrick && Julius && Hung-Te， May need your help to review again
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48953 )
Change subject: soc/mediatek: dsi: tune the dphy time by eotp enable ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48953/3//COMMIT_MSG Commit Message:
PS3: Please squash this patch into CB:48868, since they're the same fix.
https://review.coreboot.org/c/coreboot/+/48953/3//COMMIT_MSG@9 PS3, Line 9: Eotp will make the line time larger than disable Eotp. So Enabling EoTp will make the line time larger, so
jitao shi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48953 )
Change subject: soc/mediatek: dsi: tune the dphy time by eotp enable ......................................................................
Abandoned
-
jitao shi (Code Review) -
Wentao Qin (Code Review)
-
Yu-Ping Wu (Code Review)