Attention is currently required from: Bora Guvendik, Kangheui Won, Selma Bensaid, Paul Menzel, Reka Norman, Rizwan Qureshi, Krishna P Bhat D, Patrick Rudolph.
Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61162 )
Change subject: soc/intel/common: Re-use Alder Lake-M device IDs for Alder Lake-N
......................................................................
Patch Set 6:
(2 comments)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/61162/comment/d1d967c7_92d61b87
PS5, Line 3608: #define PCI_DEVICE_ID_INTEL_ADP_M_I2C0 0x54e8
ADL-N has also same id for I2C0-I2C3, why not change these?
Ack
https://review.coreboot.org/c/coreboot/+/61162/comment/7029c5aa_50feb04e
PS5, Line 3683: #define PCI_DEVICE_ID_INTEL_ADP_M_UART3 0x54da
Same here for UART3
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61162
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6042017c6189cbc3ca9dce0e50acfb68ea4003f1
Gerrit-Change-Number: 61162
Gerrit-PatchSet: 6
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Feb 2022 06:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Gerrit-MessageType: comment