Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44774 )
Change subject: mb: remove duplicated Make code for spd.bin generation
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44774/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44774/4//COMMIT_MSG@9
PS4, Line 9: Drop duplicated code for spd.bin generation that is provided globally
: in lib/Makefile.inc.
grep -ri spd src/mainboard ;; IMO that is so obvious that there is no need to document this
With `grep -ri spd src/mainboard` I get a lot of false-positives too. Using `grep -r "SPD_BIN"` I found some more.
./google/rambi/variants/ninja/Makefile.inc
./intel/cannonlake_rvp/spd/Makefile.inc
./intel/icelake_rvp/spd/Makefile.inc
./intel/jasperlake_rvp/spd/Makefile.inc
./intel/kblrvp/spd/Makefile.inc
./razer/blade_stealth_kbl/spd/Makefile.inc
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd3ac0fd6c901228554115c6350d88bb49874587
Gerrit-Change-Number: 44774
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:09:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment