Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38318 )
Change subject: soc/intel/skylake: Call mainboard ACPI sleep methods ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6:
Did already have a mainboard level MPTS/MWAK change on top for skylake mainboard? Otherwise the code will not do anything.
Mainboards would implement MPTS/MWAK methods if they needed to, I imagine. The mainboard that I've mostly completed a port for is going to be using it, so I thought I'd try getting this edit into the SoC-level ACPI code.
Then that will be more than just skylake, what about all the other SOC? If put two commits together to review will be better.
Some of the SoCs already do this by including the common SoC code. However, you are right; I'll wait on this until I have a port that will call it.