Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56627 )
Change subject: include/spd: Fix SPD Memory Type as per JEDEC Standard No. 21-C
......................................................................
Patch Set 3:
(1 comment)
File src/include/spd.h:
https://review.coreboot.org/c/coreboot/+/56627/comment/89ca1839_700c9cae
PS3, Line 204: 0x04
Looking at the rest of the CLs in the patch series, it looks like we have been converting module type for different memory technologies into the module type for DDR2. So the value 0x04 here was correct for DDR2. Please see comment https://review.coreboot.org/c/coreboot/+/56650/comment/cb91dcb6_4210c12b/ on how to fix this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I356b322fabd7ceeaefda60bcc5438eb4a64675ed
Gerrit-Change-Number: 56627
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 28 Jul 2021 18:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment