Attention is currently required from: Michał Żygowski, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74343 )
Change subject: security/vboot: Add function to clear recovery request ......................................................................
Patch Set 3:
(2 comments)
File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/74343/comment/7a5b0265_517afed8 PS3, Line 26: if (!vboot_recovery_mode_enabled()) FWIW in vb2api_kernel_phase2() we call it unconditionally without checking this first (it doesn't hurt in the non-recovery case). Probably best to do the same here for consistency (I think otherwise you can get the subcode stuck for longer than intended in some cases).
https://review.coreboot.org/c/coreboot/+/74343/comment/5c03931a_60ccc3f8 PS3, Line 34: save_vbnv_flash(ctx->nvdata); It would be good to not have to do this here. Currently this is called from BS_POST_DEVICE/ON_EXIT, so probably best to just make sure this gets called before that (e.g. POST_DEVICE/ON_ENTRY).
-
Julius Werner (Code Review)