Attention is currently required from: Michał Żygowski.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68944 )
Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block ......................................................................
Patch Set 2:
(5 comments)
File src/soc/intel/common/block/oc_wdt/oc_wdt.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161580): https://review.coreboot.org/c/coreboot/+/68944/comment/cf723aa0_a65e8809 PS2, Line 65: readback = inl(PCH_OC_WDT_CTL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161580): https://review.coreboot.org/c/coreboot/+/68944/comment/64b44fc3_390a0cbd PS2, Line 65: readback = inl(PCH_OC_WDT_CTL); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161580): https://review.coreboot.org/c/coreboot/+/68944/comment/17e26c32_777c51db PS2, Line 65: readback = inl(PCH_OC_WDT_CTL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161580): https://review.coreboot.org/c/coreboot/+/68944/comment/fd38a583_a85824e4 PS2, Line 80: printk (BIOS_ERR, "Watchdog: Failure detected\n"); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161580): https://review.coreboot.org/c/coreboot/+/68944/comment/5a6b6bf2_eb232522 PS2, Line 188: printk (BIOS_ERR, "Watchdog: timer expiration detected.\n"); space prohibited between function name and open parenthesis '('