Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Fred Reitberger, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66994 )
Change subject: soc/amd: Refactor DPTC Tablet Mode ......................................................................
Patch Set 12:
(3 comments)
File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/66994/comment/a1c40fca_ef5125e3 PS9, Line 34: true
quote
Done
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/66994/comment/baeff4f4_41b5c41a PS10, Line 91: /* Enable dptc tablet mode */ : bool dptc_tablet_mode_enable;
Hrmm, how about you reorder your Cls. Move the CL that deletes the tablet mode before this one.
`acpigen_write_alib_dptc()` requires good (non-null) values for `tablet_param` and `tablet_param_len`, so we can't remove tablet mode without this refactor first.
I would also just delete the dptc_enable bit in that CL.
See the comment below.
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/66994/comment/1a7e5845_c913a0ab PS10, Line 120: /* Enable dptc for tablet mode */ : bool dptc_enable;
So in reality this bit is already doing what you want. […]
As you pointed out, removing `dptc_enable` means the default DPTC settings can't be set without also including either tablet or no battery settings also.
I'm going to leave it, since I these are three distinct options: 1. Default DPTC 2. Tablet DPTC 3. No Battery DPTC
The only thing special about the default DPTC is that it must be specified if tablet or no battery are enabled, so we have default values to restore when the device leaves those modes.