Attention is currently required from: Dinesh Gehlot.
Yu-Ping Wu has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83686?usp=email )
Change subject: src: Enforce CSE sync with pertinent GBB flag ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83686/comment/cc766bb4_43bb64ef?usp... : PS1, Line 13: CB `CL`
BTW, I don't think we need to mention that un-merged patch here.
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/83686/comment/4f9d078d_ad188559?usp... : PS1, Line 776: - CSE Update not required This condition is not handled here, so please either move the condition here, or remove this line of comment.
https://review.coreboot.org/c/coreboot/+/83686/comment/5f479ebf_d95f58d5?usp... : PS1, Line 1068: if (is_cse_sync_enforced()) { Is this supposed to be called only if `cse_compare_sub_part_version` returns 0 (as we're doing in the other caller)?