Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42645 )
Change subject: sb/intel/i82801{gx,jx}/nvs.h: Add include guards ......................................................................
sb/intel/i82801{gx,jx}/nvs.h: Add include guards
Change-Id: Ib7eb3469b03fd58afa1f6cb5822f7c6f1cac35e0 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/i82801gx/nvs.h M src/southbridge/intel/i82801jx/nvs.h 2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/42645/1
diff --git a/src/southbridge/intel/i82801gx/nvs.h b/src/southbridge/intel/i82801gx/nvs.h index 6b697f2..3f44330 100644 --- a/src/southbridge/intel/i82801gx/nvs.h +++ b/src/southbridge/intel/i82801gx/nvs.h @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef SOUTHBRIDGE_INTEL_I82801GX_NVS_H +#define SOUTHBRIDGE_INTEL_I82801GX_NVS_H #include <stdint.h>
typedef struct { @@ -97,3 +99,5 @@ } __packed global_nvs_t;
void acpi_create_gnvs(global_nvs_t *gnvs); + +#endif /* SOUTHBRIDGE_INTEL_I82801GX_NVS_H */ diff --git a/src/southbridge/intel/i82801jx/nvs.h b/src/southbridge/intel/i82801jx/nvs.h index 6b697f2..c487918 100644 --- a/src/southbridge/intel/i82801jx/nvs.h +++ b/src/southbridge/intel/i82801jx/nvs.h @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef SOUTHBRIDGE_INTEL_I82801JX_NVS_H +#define SOUTHBRIDGE_INTEL_I82801JX_NVS_H #include <stdint.h>
typedef struct { @@ -97,3 +99,5 @@ } __packed global_nvs_t;
void acpi_create_gnvs(global_nvs_t *gnvs); + +#endif /* SOUTHBRIDGE_INTEL_I82801JX_NVS_H */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42645 )
Change subject: sb/intel/i82801{gx,jx}/nvs.h: Add include guards ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42645/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/nvs.h:
https://review.coreboot.org/c/coreboot/+/42645/1/src/southbridge/intel/i8280... PS1, Line 5: #include <stdint.h> maybe insert an empty line between include and the guard ?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42645 )
Change subject: sb/intel/i82801{gx,jx}/nvs.h: Add include guards ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42645/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/nvs.h:
https://review.coreboot.org/c/coreboot/+/42645/1/src/southbridge/intel/i8280... PS1, Line 5: #include <stdint.h>
maybe insert an empty line between include and the guard ?
i82801ix does not have any spaces. Moreover, this change is to make diffstats more meaningful, so adding a space in this commit would just add noise.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42645 )
Change subject: sb/intel/i82801{gx,jx}/nvs.h: Add include guards ......................................................................
Patch Set 2: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42645 )
Change subject: sb/intel/i82801{gx,jx}/nvs.h: Add include guards ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42645 )
Change subject: sb/intel/i82801{gx,jx}/nvs.h: Add include guards ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42645 )
Change subject: sb/intel/i82801{gx,jx}/nvs.h: Add include guards ......................................................................
sb/intel/i82801{gx,jx}/nvs.h: Add include guards
Change-Id: Ib7eb3469b03fd58afa1f6cb5822f7c6f1cac35e0 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42645 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/i82801gx/nvs.h M src/southbridge/intel/i82801jx/nvs.h 2 files changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801gx/nvs.h b/src/southbridge/intel/i82801gx/nvs.h index 6b697f2..3f44330 100644 --- a/src/southbridge/intel/i82801gx/nvs.h +++ b/src/southbridge/intel/i82801gx/nvs.h @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef SOUTHBRIDGE_INTEL_I82801GX_NVS_H +#define SOUTHBRIDGE_INTEL_I82801GX_NVS_H #include <stdint.h>
typedef struct { @@ -97,3 +99,5 @@ } __packed global_nvs_t;
void acpi_create_gnvs(global_nvs_t *gnvs); + +#endif /* SOUTHBRIDGE_INTEL_I82801GX_NVS_H */ diff --git a/src/southbridge/intel/i82801jx/nvs.h b/src/southbridge/intel/i82801jx/nvs.h index 6b697f2..c487918 100644 --- a/src/southbridge/intel/i82801jx/nvs.h +++ b/src/southbridge/intel/i82801jx/nvs.h @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef SOUTHBRIDGE_INTEL_I82801JX_NVS_H +#define SOUTHBRIDGE_INTEL_I82801JX_NVS_H #include <stdint.h>
typedef struct { @@ -97,3 +99,5 @@ } __packed global_nvs_t;
void acpi_create_gnvs(global_nvs_t *gnvs); + +#endif /* SOUTHBRIDGE_INTEL_I82801JX_NVS_H */
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)