Change in coreboot[master]: soc/amd/common/block/include/lpc: add missing LPC_PCI_CONTROL bit defs - coreboot-gerrit

29 Nov 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59674 )
Change subject: soc/amd/common/block/include/lpc: add missing LPC_PCI_CONTROL bit defs
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59674/comment/a3743208_5e801e93 
PS1, Line 10: LPC_PCI_CONTROL
...
Do we actually need to define these bits? Is anyone going to use them?
i'm not really planning to use those, but those might be needed for the !DISABLE_SPI_FLASH_ROM_SHARING case, so i'd say that it's a good idea to at least add those definitions
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59674
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I855e640d020daf21c9f5b2f62a2ad0fd0274a575
Gerrit-Change-Number: 59674
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Mon, 29 Nov 2021 20:52:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment