Attention is currently required from: Felix Singer, Jonathon Hall.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82872?usp=email )
Change subject: mb/purism/librem_skl: Prefer include <soc/gpio.h> via <gpio.h>
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
@ehaouas@noos. […]
not "must" but Prefer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4bb0f0b6fff2953ec9cc3a52704b04ccc8e8098
Gerrit-Change-Number: 82872
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Comment-Date: Wed, 19 Jun 2024 22:28:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm