Change in coreboot[master]: mb/starlabs/labtop: Store serial number in CMOS - coreboot-gerrit

9 Dec 2021


      Attention is currently required from: Andy Pont, Paul Menzel.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59979 )
Change subject: mb/starlabs/labtop: Store serial number in CMOS
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/starlabs/labtop/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59979/comment/f5fae636_2a614fd2 
PS4, Line 50: 	if (num > 99999)
...
In which case does the fallback option in get_uint_option to be 99999 rather than 0?
Good point
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70c35c8f99f7e3ac8e45e742156dca741a6c6933
Gerrit-Change-Number: 59979
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes admin@starlabs.systems
Gerrit-Reviewer: Andy Pont andy.pont@sdcsystems.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Andy Pont andy.pont@sdcsystems.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 09 Dec 2021 12:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes admin@starlabs.systems
Comment-In-Reply-To: Andy Pont andy.pont@sdcsystems.com
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment