[M] Change in coreboot[main]: mb/intel/avenuecity_crb: Update SMBIOS type 0,1,2,3 info - coreboot-gerrit

4 Jul 2024


      Attention is currently required from: Felix Singer, Jincheng Li, Lean Sheng Tan, Patrick Rudolph.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83328?usp=email )
Change subject: mb/intel/avenuecity_crb: Update SMBIOS type 0,1,2,3 info
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/intel/avenuecity_crb/Kconfig:
https://review.coreboot.org/c/coreboot/+/83328/comment/916b036c_3fb77c67?usp... :
PS1, Line 27: 	default "Intel Corporation"
...
Seems superfluous. Mainboard vendor is configured in the upper Kconfig file.
Here the intention is to leave a slot for users to override the values, do you think it is necessary to keep?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83328?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8e68c057fefa1d408fb8d69fef066cb573c929a4
Gerrit-Change-Number: 83328
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jincheng Li jincheng.li@intel.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Jincheng Li jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 04 Jul 2024 01:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de