Attention is currently required from: Angel Pons, Christian Walter, Johnny Lin, Morgan Jang, Patrick Rudolph, yuchi.chen@intel.com.
Paul Menzel has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85492?usp=email )
Change subject: mb/ocp/tiogapass: Wait for BMC
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85492/comment/7f4a04cf_dd787aee?usp... :
PS5, Line 15: Fixes lot's of error messages about not working IPMI.
Paste one of these error messages?
https://review.coreboot.org/c/coreboot/+/85492/comment/ccb82ee9_cb901171?usp... :
PS5, Line 17: Once GPP_F4 is low IPMI communication over the KCS is also
: working on ocp/tiogapass.
:
Paste the new log message with the elapsed time?
File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/85492/comment/8f76dfbb_0cba9ab0?usp... :
PS5, Line 61: timeout
Add the unit to the name?
https://review.coreboot.org/c/coreboot/+/85492/comment/14ce0554_7c94344d?usp... :
PS5, Line 70: %ldms
Add a space before the unit?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85492?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I925aff1ff1ffd3d7388835e62aad2ba339e52472
Gerrit-Change-Number: 85492
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Tue, 10 Dec 2024 10:34:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes