Attention is currently required from: Aseda Aboagye, Ivan Chen, Tim Wawrzynczak, Teddy Shih, Paul Fagerburg, Karthik Ramasubramanian, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62801 )
Change subject: mb/google/dedede/var/beadrix: Enable LTE function by FW_CONFIG option
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/beadrix/gpio.c:
https://review.coreboot.org/c/coreboot/+/62801/comment/729935df_18ee346a
PS1, Line 91: BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL);
could fw_config_handle also be called directly from the mainboard code? i'd say that calling it via […]
Honestly, it's a little bit of cargo culting at this point...
if you search
`git grep 'BOOT_STATE_INIT_ENTRY.*fw_config_handle'`
you will find it used a lot, I think this all started with volteer.
You're not wrong though, it would probably be cleaner to just call from mainboard functions instead of BS entries, especially considering most x86 google mainboards are going to use fw_config to handle GPIOs....
I've also been trying to think of a cleaner way to handle GPIO programming w/r/t fW_config, but haven't come up with anything concrete yet
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icea44992e2e3195d1fd9a888f5ce4650f82280bb
Gerrit-Change-Number: 62801
Gerrit-PatchSet: 1
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jack Cheng
jack.cheng@ecs.corp-partner.google.com
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 17 Mar 2022 15:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment