Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37016 )
Change subject: security/intel/txt: Add Intel TXT support ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/comm... File src/security/intel/txt/common.c:
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/comm... PS7, Line 53: >>
Are these aligned to something in particular?
Done
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/comm... PS7, Line 274: cold reboot
just a note the register resets on cold boot. […]
Ack
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/gets... File src/security/intel/txt/getsec.c:
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/gets... PS7, Line 65: 0x1f
That's taken from some TXT Spec. […]
Ack
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/logg... File src/security/intel/txt/logging.c:
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/logg... PS7, Line 18: static void log_txt_error(const char *phase)
SINIT ACM errors are handled differently from BIOS ACM errors
Ack
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/txt_... File src/security/intel/txt/txt_register.h:
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/txt_... PS7, Line 205: __packed
nit: putting `__packed` before the opening brace of the struct should result in a build failure in c […]
Ack
-
Angel Pons (Code Review)