[L] Change in coreboot[main]: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series

[Benjamin Doron (Code Review)]

Attention is currently required from: Alicja Michalska, Angel Pons, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan.

Benjamin Doron has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )

Change subject: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series
......................................................................

Patch Set 9:

(3 comments)

File src/mainboard/hardkernel/odroid-h4/Kconfig:

https://review.coreboot.org/c/coreboot/+/83979/comment/bbec625b_3012a024?usp... :
PS9, Line 10: 	select FSP_TYPE_IOT
Is this needed? I remember the IoT FSP had some clock and power gating UPDs for PCIe RPs, is that it here?

https://review.coreboot.org/c/coreboot/+/83979/comment/50080eaf_e9d7b8c4?usp... :
PS9, Line 18: 	select USE_LEGACY_8254_TIMER
Do you want this in the board config, and as a select? I think it should be the user's/payload's choice

File src/mainboard/hardkernel/odroid-h4/bootblock.c:

https://review.coreboot.org/c/coreboot/+/83979/comment/e408410b_b7bdffc2?usp... :
PS9, Line 13: ite_reg_write(GPIO_DEV, 0x26, 0xfb);
            : 	ite_reg_write(GPIO_DEV, 0x29, 0x01);
            : 	ite_reg_write(GPIO_DEV, 0x2c, 0x41);
            : 	ite_reg_write(GPIO_DEV, 0x2d, 0x02);
            : 	ite_reg_write(GPIO_DEV, 0xbc, 0xc0);
            : 	ite_reg_write(GPIO_DEV, 0xbd, 0x03);
            : 	ite_reg_write(GPIO_DEV, 0xc1, 0x0a);
            : 	ite_reg_write(GPIO_DEV, 0xc8, 0x00);
            : 	ite_reg_write(GPIO_DEV, 0xc9, 0x0a);
            : 	ite_reg_write(GPIO_DEV, 0xda, 0xb0);
            : 	ite_reg_write(GPIO_DEV, 0xdb, 0x44);
Do we know what this does?