Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad Th...

List overview All Threads
Download

newer

older

Change in vboot[master]: Allow...

Change in coreboot[master]:...

Johnny Li (Code Review)

22 Jun 2020 22 Jun '20

6:42 a.m.

Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 28 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/1

diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 9e5ef4b..076faf7 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -1,4 +1,32 @@ chip soc/intel/tigerlake + register "common_soc_config" = "{ + .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 163, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, + }" device domain 0 on device pci 15.0 on chip drivers/i2c/generic

Attachments:

attachment.htm (text/html — 4.5 KB)

Show replies by date

build bot (Jenkins) (Code Review)

22 Jun 22 Jun

6:42 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/42678/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42678/1/src/mainboard/google/voltee... PS1, Line 9: .speed = I2C_SPEED_FAST, trailing whitespace

https://review.coreboot.org/c/coreboot/+/42678/1/src/mainboard/google/voltee... PS1, Line 12: .speed = I2C_SPEED_FAST, trailing whitespace

https://review.coreboot.org/c/coreboot/+/42678/1/src/mainboard/google/voltee... PS1, Line 15: .speed = I2C_SPEED_FAST, trailing whitespace

https://review.coreboot.org/c/coreboot/+/42678/1/src/mainboard/google/voltee... PS1, Line 18: .speed = I2C_SPEED_FAST, trailing whitespace

Johnny Li (Code Review)

8:41 a.m.

Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Abandoned

build fail

Johnny Li (Code Review)

10:26 a.m.

Johnny Li has restored this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Restored

Johnny Li (Code Review)

10:37 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#2).

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 27 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/2

Johnny Li (Code Review)

10:58 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#3).

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Lijohnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 27 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/3

Johnny Li (Code Review)

10:59 a.m.

Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Patch Set 3: Code-Review+1

Johnny Li (Code Review)

11:03 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#4).

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 42 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/4

Johnny Li (Code Review)

11:14 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#5).

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/5

Paul Menzel (Code Review)

12:18 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Patch Set 5:

(4 comments)

https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@7 PS5, Line 7: mb/google/volteer/variants/volteer : Please remove the space before the colon.

https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@8 PS5, Line 8: This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency Please add a blank line above to separate the commit message summary from the body.

https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@8 PS5, Line 8: scl_lcnt,scl_hcnt,scl_hcnt Please add a space after each ,.

https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@9 PS5, Line 9: closer to 400kHz. What is the current frequency (before the patch)?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 22 Jun 2020 12:18:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mark Hsieh (Code Review)

23 Jun 23 Jun

8:05 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Mark Hsieh has uploaded a new patch set (#6) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

The current frequency is 367kHz. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/6

Mark Hsieh (Code Review)

8:14 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad

Mark Hsieh has uploaded a new patch set (#7) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad

The current frequency is 367kHz. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/7

Paul Menzel (Code Review)

8:18 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad ......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@7 PS7, Line 7: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad Maybe:

...

Increase I2C5 bus freq closer to 400 kHZ for trackpad

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@9 PS7, Line 9: The current frequency is 367kHz. Please also add the problem.

...

The current I2C5 bus frequency is 367 kHZ, causing the trackpad not to work.

or: operating outside the trackpad specification

(I do not have access to the bug report.)

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@10 PS7, Line 10: This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency Please break the long line after 75 characters.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 23 Jun 2020 08:18:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mark Hsieh (Code Review)

9:16 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to ...

Mark Hsieh has uploaded a new patch set (#8) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad ......................................................................

mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad

The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/8

Mark Hsieh (Code Review)

9:17 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to ...

Mark Hsieh has uploaded a new patch set (#9) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad ......................................................................

mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad

The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/9

Mark Hsieh (Code Review)

9:20 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to ...

Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad ......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@7 PS7, Line 7: mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad

...

Maybe: […]

Done

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@9 PS7, Line 9: The current frequency is 367kHz.

...

Please also add the problem. […]

Done

https://review.coreboot.org/c/coreboot/+/42678/7//COMMIT_MSG@10 PS7, Line 10: This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency

...

Please break the long line after 75 characters.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 9 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 23 Jun 2020 09:20:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Johnny Li (Code Review)

29 Jun 29 Jun

2:25 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to ...

Johnny Li has removed Mark Hsieh from this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad ......................................................................

Removed reviewer Mark Hsieh.

Johnny Li (Code Review)

3:50 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#10).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 28 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/10

Johnny Li (Code Review)

30 Jun 30 Jun

1:23 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#11).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/11

build bot (Jenkins) (Code Review)

1:24 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42678/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42678/11/src/mainboard/google/volte... PS11, Line 202: }, trailing whitespace

https://review.coreboot.org/c/coreboot/+/42678/11/src/mainboard/google/volte... PS11, Line 211: }, trailing whitespace

https://review.coreboot.org/c/coreboot/+/42678/11/src/mainboard/google/volte... PS11, Line 220: }, trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 11 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 01:24:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Johnny Li (Code Review)

1:26 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to ...

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#12).

Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad ......................................................................

mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad

The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/12

Johnny Li (Code Review)

1:47 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#13).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/13

Johnny Li (Code Review)

1:48 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#14).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/14

Johnny Li (Code Review)

1:51 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#15).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/15

Johnny Li (Code Review)

1:51 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#16).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/16

Caveh Jalali (Code Review)

3:43 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

Patch Set 16:

there are a lot of changes here beyond supporting the trackpad. could you separate them, perhaps by peripheral?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 16 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 03:43:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Johnny Li (Code Review)

5:50 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad,Au...

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#17).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad,Audio,Touchscreen, WLAN, SAR0,Camera, SAR1 Camera ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad,Audio,Touchscreen, WLAN, SAR0,Camera, SAR1 Camera

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726,b:153588771 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 17 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

6:11 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 pa...

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#18).

Change subject: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN, SAR0,Camera, SAR1 Camera ......................................................................

mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN, SAR0,Camera, SAR1 Camera

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C0,I2C1,I2C2,I2C3,I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726,b:153588771 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 18 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

6:20 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 pa...

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#19).

mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN, SAR0,Camera, SAR1 Camera

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C0,I2C1,I2C2,I2C3,I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726,b:153588771 TEST= Verified that I2C0,I2C1,I2C2,I2C3,I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/19

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 19 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nick Chen (Code Review)

6:23 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 pa...

Nick Chen has uploaded a new patch set (#20) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN,SAR0,Camera,SAR1 Camera ......................................................................

mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN,SAR0,Camera,SAR1 Camera

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C0,I2C1,I2C2,I2C3,I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726,b:153588771 TEST= Verified that I2C0,I2C1,I2C2,I2C3,I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 20 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nick Chen (Code Review)

6:47 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 pa...

Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN,SAR0,Camera,SAR1 Camera ......................................................................

Patch Set 20:

...

Patch Set 16:

there are a lot of changes here beyond supporting the trackpad. could you separate them, perhaps by peripheral?

Because b:153588771 contains b:157999726, we change issue description and issue id for b:153588771. And we will duplicate b:157999726 on issue tracker.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 20 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Caveh Jalali caveh@chromium.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 06:47:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Caveh Jalali (Code Review)

7:51 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 pa...

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN,SAR0,Camera,SAR1 Camera ......................................................................

Patch Set 20:

i would still suggest splitting this patch up into a separate patch for each peripheral or I2C bus.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 20 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 07:51:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Johnny Li (Code Review)

11:30 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad,Au...

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#21).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad,Audio,Touchscreen, WLAN,SAR0,Camera,SAR1 Camera ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad,Audio,Touchscreen, WLAN,SAR0,Camera,SAR1 Camera

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 21 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

11:31 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#22).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/22

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 22 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

11:42 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42678

to look at the new patch set (#23).

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.

Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 117 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42678/23

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 23 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

11:45 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

Abandoned

caveh would still suggest splitting this patch up into a separate patch for each peripheral or I2C bus.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 23 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

Paul Menzel (Code Review)

1:52 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )

Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................

Patch Set 23:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42678/23//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42678/23//COMMIT_MSG@7 PS23, Line 7: mb/google/volteer/variants/volteer : Please remove the space before the colon.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6 Gerrit-Change-Number: 42678 Gerrit-PatchSet: 23 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 13:52:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1554

days inactive

1562

days old

coreboot-gerrit@coreboot.org

36 comments

6 participants

tags (0)

participants (6)

build bot (Jenkins) (Code Review)
Caveh Jalali (Code Review)
Johnny Li (Code Review)
Mark Hsieh (Code Review)
Nick Chen (Code Review)
Paul Menzel (Code Review)