Attention is currently required from: Tony Huang, Paul Fagerburg, Wisley Chen, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49627 )
Change subject: mb/google/dedede/var/lantis: Update DPTF parameters
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49627/comment/29024071_bb2b9cde
PS1, Line 9: form
Please correct this typo "from".
File src/mainboard/google/dedede/variants/lantis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/49627/comment/c7de5acc_f4712096
PS1, Line 103: Charger
For which sensor this Charger Performance Control being used ?
There is no entry for charger sensor under Passive policy table at above line 75.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19654b65613817ebecf979ce7ac4f76d370ebdc2
Gerrit-Change-Number: 49627
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 19 Jan 2021 05:21:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment