Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Elyes Haouas, Felix Held, Felix Singer, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, niehaitao@bytedance.com.
TangYiwei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email )
Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs
......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/bytedance/bd_egs/Kconfig:
https://review.coreboot.org/c/coreboot/+/75722/comment/b13e8d3b_ab7a1b34 :
PS10, Line 32: default "\_SB.C%03d"
Hi Yiwei, could you check if you remove this line will it still works on your side?
Hi Sheng,
It's workable on my side because below PR has been merged,
https://review.coreboot.org/c/coreboot/+/73368
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75722?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d
Gerrit-Change-Number: 75722
Gerrit-PatchSet: 13
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: niehaitao@bytedance.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: laykong
lay.kong@intel.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: niehaitao@bytedance.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 27 Jun 2023 02:55:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Comment-In-Reply-To: TangYiwei
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment