Attention is currently required from: Alicja Michalska, Benjamin Doron, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan, Marvin Drees, Matt DeVillier.
Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series ......................................................................
Patch Set 11:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83979/comment/2e36178d_cb25097f?usp... : PS10, Line 22: - S3 suspend/resume
Windows 10 BSODs after resuming with `TDR_RECOVERY_FAILURE`, no idea why though. […]
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/c7434cdb_1887dc52?usp... : PS10, Line 27: - Dual BIOS: flash chip switching mechanism is very sus
I was told this is broken on the board I'm testing with, so it's not a coreboot issue.
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/67d42dd7_90413237?usp... : PS10, Line 32: - Fan control: seems wonky because of onboard temp sensor
Might need to adjust thresholds but should work with the thermal resistor (PECI doesn't work)
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/4e53cb6a_5f724ac1?usp... : PS10, Line 33: - Rest of Super I/O config: needs exorcism
Seems fine
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/da172aa8_7552d324?usp... : PS10, Line 35: - M.2 slot (PCIe only, no SATA lanes)
Tested and working
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/24e47a8d_7e50774b?usp... : PS10, Line 36: - Windows (with edk2 payload)
Tested and working
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/94ca5d91_e4f576a0?usp... : PS10, Line 37: - PCIe ASPM and friends
PCIe devices seem fine
Done
File src/mainboard/hardkernel/odroid-h4/gpio.h:
PS7:
I'm not even sure what the VGPIOs do, nor why they would need to be configured. […]
I don't see a need to configure the VGPIOs. About combining, refer to Matt's comment
-
Angel Pons (Code Review)