Attention is currently required from: Paul Menzel, Sergii Dmytruk, Timothy Pearson, Ron Minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57082 )
Change subject: src/mainboard/emulation/qemu-power9: require hb-mode=on
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS12:
The conditional isn't there to remove unused symbols in ramstage, it's to take change in addressing into account. I've added a comment which should explain what's going on and resolve all of your comments.
I don't really understand why just setting ramstage to the required offset won't work and redefining a lot of unused symbols is needed. Early stages don't need to know the ramstage symbol either, so I don't understand why you even need CPP in here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57082
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bdc97a095bd46fccc862985b3bd24f4fa5bc054
Gerrit-Change-Number: 57082
Gerrit-PatchSet: 13
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sat, 20 Nov 2021 09:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment