Attention is currently required from: Felix Singer.
Reto Buerki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80261?usp=email )
Change subject: mb/up/squared: Make mini PCIe port mode configurable ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80261/comment/e9f7d412_61d2ad97 : PS2, Line 9: Add ENABLE_MSATA config knob and pad configuration to put Mini PCIe port : into mSATA mode.
Did you test if the PCIe functionality still works? I'm wondering because you are not disabling the […]
Good point. My usecase always was mSATA mode, I never explicitly tested whether PCIe mode works (mainly because I have no suitable hardware, it's not very common).
The official documentation (https://doc.coreboot.org/mainboard/up/squared/index.html) lists mini PCIe as untested.
What do you suggest?
Patchset:
PS2: Thanks for your review.
File src/mainboard/up/squared/Kconfig:
https://review.coreboot.org/c/coreboot/+/80261/comment/654ab227_f01e7a8f : PS2, Line 77: config ENABLE_MSATA : bool "Use mini-PCIe port for mSATA" : default n
I think a choice menu would be better since the distinction between both functions (SATA vs PCIe) is […]
I used `mb/compulab/intense_pc` as a template, which provides the same `ENABLE_MSATA` knob. Will update the patch if you still prefer the choice menu variant.