Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34803 )
Change subject: arch/x86: Enable POSTCAR_CONSOLE by default ......................................................................
arch/x86: Enable POSTCAR_CONSOLE by default
Almost all platforms force it on. Make it enabled by default but under user control to optionally disable it.
Change-Id: I6b0f19c8bfd6ffed93023d57a1d28ca6acc06835 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/console/Kconfig M src/drivers/intel/fsp1_1/Kconfig M src/mainboard/emulation/qemu-i440fx/Kconfig M src/mainboard/emulation/qemu-q35/Kconfig M src/mainboard/intel/galileo/Kconfig M src/northbridge/intel/gm45/Kconfig M src/northbridge/intel/haswell/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/nehalem/Kconfig M src/northbridge/intel/pineview/Kconfig M src/northbridge/intel/sandybridge/Kconfig M src/northbridge/intel/x4x/Kconfig M src/soc/amd/picasso/Kconfig M src/soc/amd/stoneyridge/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/baytrail/Kconfig M src/soc/intel/broadwell/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/icelake/Kconfig M src/soc/intel/skylake/Kconfig 21 files changed, 1 insertion(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/34803/1
diff --git a/src/console/Kconfig b/src/console/Kconfig index 4cb407e..5d505d2 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -13,7 +13,7 @@ config POSTCAR_CONSOLE bool "Enable console output during postcar." depends on POSTCAR_STAGE - default n + default y help Use console during the postcar if supported
diff --git a/src/drivers/intel/fsp1_1/Kconfig b/src/drivers/intel/fsp1_1/Kconfig index da9e188..9ffec31 100644 --- a/src/drivers/intel/fsp1_1/Kconfig +++ b/src/drivers/intel/fsp1_1/Kconfig @@ -19,7 +19,6 @@ select UEFI_2_4_BINDING select INTEL_GMA_ADD_VBT if RUN_FSP_GOP select POSTCAR_STAGE - select POSTCAR_CONSOLE help Does the code require the Intel Firmware Support Package?
diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 23526f9..d6e90f6 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -13,7 +13,6 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select POSTCAR_STAGE - select POSTCAR_CONSOLE
config MAINBOARD_DIR string diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index 815b93b..e5ae6cd 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -12,7 +12,6 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select POSTCAR_STAGE - select POSTCAR_CONSOLE
config MAINBOARD_DIR string diff --git a/src/mainboard/intel/galileo/Kconfig b/src/mainboard/intel/galileo/Kconfig index 0f49c7f..2c89995 100644 --- a/src/mainboard/intel/galileo/Kconfig +++ b/src/mainboard/intel/galileo/Kconfig @@ -100,7 +100,6 @@ select DISPLAY_ESRAM_LAYOUT select DISPLAY_FSP_CALLS_AND_STATUS select DISPLAY_FSP_HEADER - select POSTCAR_CONSOLE select VERIFY_HOBS help Turn on debug support to display HOBS, MTRRS, SMM_MEMORY_MAP, UPD_DATA diff --git a/src/northbridge/intel/gm45/Kconfig b/src/northbridge/intel/gm45/Kconfig index 576ae47..b07eeb5 100644 --- a/src/northbridge/intel/gm45/Kconfig +++ b/src/northbridge/intel/gm45/Kconfig @@ -27,7 +27,6 @@ select INTEL_GMA_ACPI select INTEL_GMA_SSC_ALTERNATE_REF select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP
config CBFS_SIZE diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig index dbf91bf..8a43621 100644 --- a/src/northbridge/intel/haswell/Kconfig +++ b/src/northbridge/intel/haswell/Kconfig @@ -20,7 +20,6 @@ select INTEL_DDI select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE select C_ENVIRONMENT_BOOTBLOCK select BOOTBLOCK_CONSOLE
diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index 1a4d887..48effe2 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -28,7 +28,6 @@ select INTEL_EDID select HAVE_VGA_TEXT_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP
config NORTHBRIDGE_INTEL_SUBTYPE_I945GC diff --git a/src/northbridge/intel/nehalem/Kconfig b/src/northbridge/intel/nehalem/Kconfig index 02b6e80..ee4a955 100644 --- a/src/northbridge/intel/nehalem/Kconfig +++ b/src/northbridge/intel/nehalem/Kconfig @@ -21,7 +21,6 @@ select INTEL_GMA_ACPI select CACHE_MRC_SETTINGS select POSTCAR_STAGE - select POSTCAR_CONSOLE select HAVE_DEBUG_RAM_SETUP
if NORTHBRIDGE_INTEL_NEHALEM diff --git a/src/northbridge/intel/pineview/Kconfig b/src/northbridge/intel/pineview/Kconfig index 8acfaf8..3657cdf 100644 --- a/src/northbridge/intel/pineview/Kconfig +++ b/src/northbridge/intel/pineview/Kconfig @@ -29,7 +29,6 @@ select INTEL_EDID if MAINBOARD_DO_NATIVE_VGA_INIT select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP select C_ENVIRONMENT_BOOTBLOCK
diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 53725ca..ddae860 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -21,7 +21,6 @@ select HAVE_DEBUG_RAM_SETUP select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE
if NORTHBRIDGE_INTEL_SANDYBRIDGE
diff --git a/src/northbridge/intel/x4x/Kconfig b/src/northbridge/intel/x4x/Kconfig index a819f57..165ba3f 100644 --- a/src/northbridge/intel/x4x/Kconfig +++ b/src/northbridge/intel/x4x/Kconfig @@ -27,7 +27,6 @@ select INTEL_GMA_ACPI select CACHE_MRC_SETTINGS select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP
config CBFS_SIZE diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 1c2ec84..a7ae069 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -56,7 +56,6 @@ select PARALLEL_MP_AP_WORK select HAVE_SMI_HANDLER select POSTCAR_STAGE - select POSTCAR_CONSOLE select SSE2 select RTC
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 5f1d2f3a..aa23367 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -77,7 +77,6 @@ select PARALLEL_MP_AP_WORK select HAVE_SMI_HANDLER select POSTCAR_STAGE - select POSTCAR_CONSOLE select SSE2 select RTC
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index ee74dbf..8c6fd14 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -57,7 +57,6 @@ select PCIEXP_CLK_PM select PCIEXP_L1_SUB_STATE select PCIEX_LENGTH_256MB - select POSTCAR_CONSOLE select POSTCAR_STAGE select PMC_INVALID_READ_AFTER_WRITE select PMC_GLOBAL_RESET_ENABLE_LOCK diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig index 4b816a2..9a6e6b8 100644 --- a/src/soc/intel/baytrail/Kconfig +++ b/src/soc/intel/baytrail/Kconfig @@ -37,7 +37,6 @@ select INTEL_GMA_ACPI select INTEL_GMA_SWSMISCI select POSTCAR_STAGE - select POSTCAR_CONSOLE select CPU_INTEL_COMMON select CPU_HAS_L2_ENABLE_MSR
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig index 696cf98..ff9b550 100644 --- a/src/soc/intel/broadwell/Kconfig +++ b/src/soc/intel/broadwell/Kconfig @@ -37,7 +37,6 @@ select CPU_INTEL_COMMON select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE select HAVE_POWER_STATE_AFTER_FAILURE select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE select NO_FIXED_XIP_ROM_SIZE diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 4bc6a65..0abb2f3 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -76,7 +76,6 @@ select PARALLEL_MP select PARALLEL_MP_AP_WORK select PLATFORM_USES_FSP2_0 - select POSTCAR_CONSOLE select POSTCAR_STAGE select REG_SCRIPT select SMP diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig index c230337..f931f3c 100644 --- a/src/soc/intel/denverton_ns/Kconfig +++ b/src/soc/intel/denverton_ns/Kconfig @@ -29,7 +29,6 @@ select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH select BOOT_DEVICE_SUPPORTS_WRITES select DEBUG_GPIO - select POSTCAR_CONSOLE select SOC_INTEL_COMMON select SOC_INTEL_COMMON_RESET select PLATFORM_USES_FSP2_0 diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 7931018..ce29d6b 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -32,7 +32,6 @@ select PARALLEL_MP_AP_WORK select MICROCODE_BLOB_UNDISCLOSED select PLATFORM_USES_FSP2_1 - select POSTCAR_CONSOLE select POSTCAR_STAGE select REG_SCRIPT select SMP diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index ca5968c..f4c00ec 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -92,7 +92,6 @@ select PLATFORM_USES_FSP2_0 select UDK_2015_BINDING select INTEL_GMA_ADD_VBT if RUN_FSP_GOP - select POSTCAR_CONSOLE select POSTCAR_STAGE
config USE_FSP1_1_DRIVER
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34803 )
Change subject: arch/x86: Enable POSTCAR_CONSOLE by default ......................................................................
Patch Set 1:
i have seen some soc do select postcar stage but didn't enable postcar console, i hope this CL doesn't create problem for those socs ?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34803 )
Change subject: arch/x86: Enable POSTCAR_CONSOLE by default ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34803 )
Change subject: arch/x86: Enable POSTCAR_CONSOLE by default ......................................................................
Patch Set 1:
Patch Set 1:
i have seen some soc do select postcar stage but didn't enable postcar console, i hope this CL doesn't create problem for those socs ?
Console has been user-visible option to select, so such platforms need to get fixed regardless, if any.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34803 )
Change subject: arch/x86: Enable POSTCAR_CONSOLE by default ......................................................................
Patch Set 1: Code-Review+1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34803 )
Change subject: arch/x86: Enable POSTCAR_CONSOLE by default ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34803 )
Change subject: arch/x86: Enable POSTCAR_CONSOLE by default ......................................................................
arch/x86: Enable POSTCAR_CONSOLE by default
Almost all platforms force it on. Make it enabled by default but under user control to optionally disable it.
Change-Id: I6b0f19c8bfd6ffed93023d57a1d28ca6acc06835 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34803 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Martin Roth martinroth@google.com --- M src/console/Kconfig M src/drivers/intel/fsp1_1/Kconfig M src/mainboard/emulation/qemu-i440fx/Kconfig M src/mainboard/emulation/qemu-q35/Kconfig M src/mainboard/intel/galileo/Kconfig M src/northbridge/intel/gm45/Kconfig M src/northbridge/intel/haswell/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/nehalem/Kconfig M src/northbridge/intel/pineview/Kconfig M src/northbridge/intel/sandybridge/Kconfig M src/northbridge/intel/x4x/Kconfig M src/soc/amd/picasso/Kconfig M src/soc/amd/stoneyridge/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/baytrail/Kconfig M src/soc/intel/broadwell/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/icelake/Kconfig M src/soc/intel/skylake/Kconfig 21 files changed, 1 insertion(+), 21 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/console/Kconfig b/src/console/Kconfig index 4cb407e..5d505d2 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -13,7 +13,7 @@ config POSTCAR_CONSOLE bool "Enable console output during postcar." depends on POSTCAR_STAGE - default n + default y help Use console during the postcar if supported
diff --git a/src/drivers/intel/fsp1_1/Kconfig b/src/drivers/intel/fsp1_1/Kconfig index da9e188..9ffec31 100644 --- a/src/drivers/intel/fsp1_1/Kconfig +++ b/src/drivers/intel/fsp1_1/Kconfig @@ -19,7 +19,6 @@ select UEFI_2_4_BINDING select INTEL_GMA_ADD_VBT if RUN_FSP_GOP select POSTCAR_STAGE - select POSTCAR_CONSOLE help Does the code require the Intel Firmware Support Package?
diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 23526f9..d6e90f6 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -13,7 +13,6 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select POSTCAR_STAGE - select POSTCAR_CONSOLE
config MAINBOARD_DIR string diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index 815b93b..e5ae6cd 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -12,7 +12,6 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select POSTCAR_STAGE - select POSTCAR_CONSOLE
config MAINBOARD_DIR string diff --git a/src/mainboard/intel/galileo/Kconfig b/src/mainboard/intel/galileo/Kconfig index 0f49c7f..2c89995 100644 --- a/src/mainboard/intel/galileo/Kconfig +++ b/src/mainboard/intel/galileo/Kconfig @@ -100,7 +100,6 @@ select DISPLAY_ESRAM_LAYOUT select DISPLAY_FSP_CALLS_AND_STATUS select DISPLAY_FSP_HEADER - select POSTCAR_CONSOLE select VERIFY_HOBS help Turn on debug support to display HOBS, MTRRS, SMM_MEMORY_MAP, UPD_DATA diff --git a/src/northbridge/intel/gm45/Kconfig b/src/northbridge/intel/gm45/Kconfig index 576ae47..b07eeb5 100644 --- a/src/northbridge/intel/gm45/Kconfig +++ b/src/northbridge/intel/gm45/Kconfig @@ -27,7 +27,6 @@ select INTEL_GMA_ACPI select INTEL_GMA_SSC_ALTERNATE_REF select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP
config CBFS_SIZE diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig index dbf91bf..8a43621 100644 --- a/src/northbridge/intel/haswell/Kconfig +++ b/src/northbridge/intel/haswell/Kconfig @@ -20,7 +20,6 @@ select INTEL_DDI select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE select C_ENVIRONMENT_BOOTBLOCK select BOOTBLOCK_CONSOLE
diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index 1a4d887..48effe2 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -28,7 +28,6 @@ select INTEL_EDID select HAVE_VGA_TEXT_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP
config NORTHBRIDGE_INTEL_SUBTYPE_I945GC diff --git a/src/northbridge/intel/nehalem/Kconfig b/src/northbridge/intel/nehalem/Kconfig index 02b6e80..ee4a955 100644 --- a/src/northbridge/intel/nehalem/Kconfig +++ b/src/northbridge/intel/nehalem/Kconfig @@ -21,7 +21,6 @@ select INTEL_GMA_ACPI select CACHE_MRC_SETTINGS select POSTCAR_STAGE - select POSTCAR_CONSOLE select HAVE_DEBUG_RAM_SETUP
if NORTHBRIDGE_INTEL_NEHALEM diff --git a/src/northbridge/intel/pineview/Kconfig b/src/northbridge/intel/pineview/Kconfig index 8acfaf8..3657cdf 100644 --- a/src/northbridge/intel/pineview/Kconfig +++ b/src/northbridge/intel/pineview/Kconfig @@ -29,7 +29,6 @@ select INTEL_EDID if MAINBOARD_DO_NATIVE_VGA_INIT select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP select C_ENVIRONMENT_BOOTBLOCK
diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 53725ca..ddae860 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -21,7 +21,6 @@ select HAVE_DEBUG_RAM_SETUP select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE
if NORTHBRIDGE_INTEL_SANDYBRIDGE
diff --git a/src/northbridge/intel/x4x/Kconfig b/src/northbridge/intel/x4x/Kconfig index a819f57..165ba3f 100644 --- a/src/northbridge/intel/x4x/Kconfig +++ b/src/northbridge/intel/x4x/Kconfig @@ -27,7 +27,6 @@ select INTEL_GMA_ACPI select CACHE_MRC_SETTINGS select POSTCAR_STAGE - select POSTCAR_CONSOLE select PARALLEL_MP
config CBFS_SIZE diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 5c5179d..7ace909 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -57,7 +57,6 @@ select PARALLEL_MP_AP_WORK select HAVE_SMI_HANDLER select POSTCAR_STAGE - select POSTCAR_CONSOLE select SSE2 select RTC
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 5f1d2f3a..aa23367 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -77,7 +77,6 @@ select PARALLEL_MP_AP_WORK select HAVE_SMI_HANDLER select POSTCAR_STAGE - select POSTCAR_CONSOLE select SSE2 select RTC
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index ee74dbf..8c6fd14 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -57,7 +57,6 @@ select PCIEXP_CLK_PM select PCIEXP_L1_SUB_STATE select PCIEX_LENGTH_256MB - select POSTCAR_CONSOLE select POSTCAR_STAGE select PMC_INVALID_READ_AFTER_WRITE select PMC_GLOBAL_RESET_ENABLE_LOCK diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig index 4b816a2..9a6e6b8 100644 --- a/src/soc/intel/baytrail/Kconfig +++ b/src/soc/intel/baytrail/Kconfig @@ -37,7 +37,6 @@ select INTEL_GMA_ACPI select INTEL_GMA_SWSMISCI select POSTCAR_STAGE - select POSTCAR_CONSOLE select CPU_INTEL_COMMON select CPU_HAS_L2_ENABLE_MSR
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig index 696cf98..ff9b550 100644 --- a/src/soc/intel/broadwell/Kconfig +++ b/src/soc/intel/broadwell/Kconfig @@ -37,7 +37,6 @@ select CPU_INTEL_COMMON select INTEL_GMA_ACPI select POSTCAR_STAGE - select POSTCAR_CONSOLE select HAVE_POWER_STATE_AFTER_FAILURE select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE select NO_FIXED_XIP_ROM_SIZE diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 4bc6a65..0abb2f3 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -76,7 +76,6 @@ select PARALLEL_MP select PARALLEL_MP_AP_WORK select PLATFORM_USES_FSP2_0 - select POSTCAR_CONSOLE select POSTCAR_STAGE select REG_SCRIPT select SMP diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig index c230337..f931f3c 100644 --- a/src/soc/intel/denverton_ns/Kconfig +++ b/src/soc/intel/denverton_ns/Kconfig @@ -29,7 +29,6 @@ select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH select BOOT_DEVICE_SUPPORTS_WRITES select DEBUG_GPIO - select POSTCAR_CONSOLE select SOC_INTEL_COMMON select SOC_INTEL_COMMON_RESET select PLATFORM_USES_FSP2_0 diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 7931018..ce29d6b 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -32,7 +32,6 @@ select PARALLEL_MP_AP_WORK select MICROCODE_BLOB_UNDISCLOSED select PLATFORM_USES_FSP2_1 - select POSTCAR_CONSOLE select POSTCAR_STAGE select REG_SCRIPT select SMP diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index ca5968c..f4c00ec 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -92,7 +92,6 @@ select PLATFORM_USES_FSP2_0 select UDK_2015_BINDING select INTEL_GMA_ADD_VBT if RUN_FSP_GOP - select POSTCAR_CONSOLE select POSTCAR_STAGE
config USE_FSP1_1_DRIVER
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Martin Roth (Code Review)
-
Nico Huber (Code Review)
-
Subrata Banik (Code Review)