Hello Aaron Durbin, Daisuke Nojiri, Hung-Te Lin, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31585
to look at the new patch set (#5).
Change subject: ec/google/chromeec: fix the error status handling ......................................................................
ec/google/chromeec: fix the error status handling
Various instances of google_chromeec_command() can return non-zero number (both positive and negative) to indicate error, which causes confusion for the caller. This patch attempts to address the issue by using only negative number for errors.
In addition, the patch modifies the direct/indirect callers of google_chromeec_command() such so they will treat negative number as error.
BUG=b:123676982,chromium:935038 BRANCH=kukui TEST=build with kukui/flapjack configurations Signed-off-by: YH Lin yueherngl@google.com Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c --- M src/ec/google/chromeec/crosec_proto.c M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec_i2c.c M src/ec/google/chromeec/ec_lpc.c M src/ec/google/chromeec/smihandler.c M src/ec/google/chromeec/vboot_storage.c M src/ec/google/chromeec/vstore.c M src/mainboard/google/gru/mainboard.c M src/security/vboot/vboot_logic.c 9 files changed, 30 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/31585/5