Change in coreboot[master]: drivers/i2c/at24rf08c/lenovo_serials.c: Drop unuseful if condition - coreboot-gerrit

16 Feb 2022


      Attention is currently required from: Nico Huber.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61969 )
Change subject: drivers/i2c/at24rf08c/lenovo_serials.c: Drop unuseful if condition
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/drivers/i2c/at24rf08c/lenovo_serials.c:
https://review.coreboot.org/c/coreboot/+/61969/comment/0b3e9be1_cf98785b 
PS1, Line 186: static
...
It's `static` so the function can return a prior result if called […]
static char *s = NULL;
    
    if (s != NULL)
    	return s; /* <<--- this will never happen, right ? */
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a2fa774d271fde664676697e36f9ee63f2aba20
Gerrit-Change-Number: 61969
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 15 Feb 2022 14:52:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment