Attention is currently required from: Angel Pons, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu.
Martin L Roth has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/82169?usp=email )
Change subject: mb/intel/archercity_crb: Deselect OCP drivers
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/intel/archercity_crb/Kconfig:
https://review.coreboot.org/c/coreboot/+/82169/comment/d02647cc_f9c17fde?usp... :
PS1, Line 34: config MAINBOARD_OCP_COMPABILITY
Can we name it as below? […]
Those names seem reasonable, but as Angel mentions, maybe the easier way is just to add a config file that enables this to the coreboot/configs folder. Feel free to reach out to me on google chat if you have any questions about that - gaumless@gmail.
Honestly, I'm not convinced that variants are the way to go. It's not a different board, just a different config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82169?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0c608b326ea2277412ebb659986b130697591359
Gerrit-Change-Number: 82169
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 09 Jul 2024 15:40:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com