[S] Change in coreboot[main]: soc/intel/common: Skip ME version log for Lite SKU

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83258?usp=email )

Change subject: soc/intel/common: Skip ME version log for Lite SKU
......................................................................

soc/intel/common: Skip ME version log for Lite SKU

This change skips the ME firmware version logging in
print_me_fw_version() if the ME firmware SKU is detected as Lite SKU.

The reasoning is that the RO (BP1) and RW (BP2) versions are already
logged by the cse_print_boot_partition_info() function for Lite SKUs,
making the additional log redundant.

The check for the Lite SKU has been moved to print_me_fw_version(),
where the decision to print the version is made, instead of in
get_me_fw_version(), where the version information is retrieved.

TEST=Able to build and boot google/rex.

w/o this patch:

[DEBUG]  ME: Version: Unavailable

w/ this patch:

Unable to see such debug msg.

Change-Id: Ic3843109326153d5060c2c4c25936aaa6b4cddda
Signed-off-by: Subrata Banik 
---
M src/soc/intel/common/block/cse/cse.c
1 file changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83258/1

diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index e4d57e1..0ec296c 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -880,13 +880,6 @@
    	return CB_ERR;

/*
-	 * Ignore if ME Firmware SKU type is Lite since
-	 * print_boot_partition_info() logs RO(BP1) and RW(BP2) versions.
-	 */
-	if (cse_is_hfs3_fw_sku_lite())
-		return CB_ERR;
-
-	/*
     * Prerequisites:
     * 1) HFSTS1 Current Working State is Normal
     * 2) HFSTS1 Current Operation Mode is Normal
@@ -917,6 +910,13 @@
    if (!CONFIG(CONSOLE_SERIAL))
    	return;

+	/*
+	 * Skip if ME firmware is Lite SKU, as RO/RW versions are
+	 * already logged by `cse_print_boot_partition_info()`
+	 */
+	if (cse_is_hfs3_fw_sku_lite())
+		return;
+
    if (get_me_fw_version(&resp) == CB_SUCCESS) {
    	printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major,
    		resp.code.minor, resp.code.hotfix, resp.code.build);