Change in coreboot[master]: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build ...

[Bill XIE (Code Review)]

Attention is currently required from: Nico Huber, Patrick Rudolph, Angel Pons, Julius Werner, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )

Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time
......................................................................

Patch Set 24:

(1 comment)

File src/arch/x86/bootblock.ld:

https://review.coreboot.org/c/coreboot/+/51671/comment/044b9276_f7da1d72 
PS22, Line 57: _ID_SECTION_END - _ECFW_PTR
> > It can only happen when someone messes up the code. […]

ECFW_PTR_ADDR is not a user configurable symbol, and should be a fixed value according to the EC model, so it makes little sense to restrict its value, for it may even lie in the range of another stage for a different EC.

As Nico said, it should be declared in arch/x86/Kconfig, and assigned in EC Kconfig.