Change in coreboot[master]: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h>

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

13 Jun 2020 13 Jun '20

12:54 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42342 )

Change subject: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h> ......................................................................

soc/amd/common/block/psp/psp_smm.c: Add missing <string.h>

Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/common/block/psp/psp_smm.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/42342/1

diff --git a/src/soc/amd/common/block/psp/psp_smm.c b/src/soc/amd/common/block/psp/psp_smm.c index b0f9a41..e30897a 100644 --- a/src/soc/amd/common/block/psp/psp_smm.c +++ b/src/soc/amd/common/block/psp/psp_smm.c @@ -8,6 +8,8 @@ #include <console/console.h> #include <amdblocks/psp.h> #include <soc/iomap.h> +#include <string.h> + #include "psp_def.h"

#define C2P_BUFFER_MAXSIZE 0xc00 /* Core-to-PSP buffer */

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

HAOUAS Elyes (Code Review)

10 Jul 10 Jul

4:38 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42342

to look at the new patch set (#2).

Change subject: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h> ......................................................................

soc/amd/common/block/psp/psp_smm.c: Add missing <string.h>

'memset' needs <string.h>.

Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/common/block/psp/psp_smm.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/42342/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Gerrit-Change-Number: 42342 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

4:38 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42342 )

Change subject: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h> ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42342/1/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/psp_smm.c:

https://review.coreboot.org/c/coreboot/+/42342/1/src/soc/amd/common/block/ps... PS1, Line 85: memset needs <string.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/42342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Gerrit-Change-Number: 42342 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 Jul 2020 14:38:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

25 Jul 25 Jul

8:41 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42342 )

Change subject: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h> ......................................................................

Patch Set 2:

(1 comment)

comment added to make the review easy

https://review.coreboot.org/c/coreboot/+/42342/2/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/psp_smm.c:

https://review.coreboot.org/c/coreboot/+/42342/2/src/soc/amd/common/block/ps... PS2, Line 19: u8 needs <stdint.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/42342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Gerrit-Change-Number: 42342 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 25 Jul 2020 06:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:43 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42342 )

Change subject: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h> ......................................................................

Patch Set 2:

(2 comments)

Thx

https://review.coreboot.org/c/coreboot/+/42342/2/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/psp_smm.c:

https://review.coreboot.org/c/coreboot/+/42342/2/src/soc/amd/common/block/ps... PS2, Line 19: u8

...

needs <stdint. […]

oops, this is done it another change.

https://review.coreboot.org/c/coreboot/+/42342/2/src/soc/amd/common/block/ps... PS2, Line 85: memset this needs <string.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/42342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Gerrit-Change-Number: 42342 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 25 Jul 2020 06:43:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

11:35 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42342 )

Change subject: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h> ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Gerrit-Change-Number: 42342 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 25 Jul 2020 09:35:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Jul 26 Jul

11:37 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42342 )

Change subject: soc/amd/common/block/psp/psp_smm.c: Add missing <string.h> ......................................................................

soc/amd/common/block/psp/psp_smm.c: Add missing <string.h>

'memset' needs <string.h>.

Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42342 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/psp/psp_smm.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/soc/amd/common/block/psp/psp_smm.c b/src/soc/amd/common/block/psp/psp_smm.c index f919668..92b0cc6 100644 --- a/src/soc/amd/common/block/psp/psp_smm.c +++ b/src/soc/amd/common/block/psp/psp_smm.c @@ -9,6 +9,8 @@ #include <console/console.h> #include <amdblocks/psp.h> #include <soc/iomap.h> +#include <string.h> + #include "psp_def.h"

#define C2P_BUFFER_MAXSIZE 0xc00 /* Core-to-PSP buffer */

-- To view, visit https://review.coreboot.org/c/coreboot/+/42342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc1d72e92c97cd5139ae7439aadb575ef011129a Gerrit-Change-Number: 42342 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1563

days inactive

1606

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)