Attention is currently required from: Arthur Heymans, Felix Held, Matt DeVillier, Matt DeVillier.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76502?usp=email )
Change subject: soc/amd/genoa/southbridge.h: Add PM related macros
......................................................................
Patch Set 10:
(1 comment)
File src/soc/amd/genoa/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/76502/comment/94362d9d_b9657e14 :
PS9, Line 120: void fch_final(void *chip_info);
is this implemented in a subsequent commit? it's kind of hidden here given the commit subject, might […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76502?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If288079310ba74333f04173978f6a123ce95f4d9
Gerrit-Change-Number: 76502
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 27 Sep 2023 16:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment