Attention is currently required from: Sean Rhodes, Andy Pont, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60123 )
Change subject: mb/starlabs/labtop: Tidy up GPIOs ......................................................................
Patch Set 11:
(5 comments)
File src/mainboard/starlabs/labtop/variants/tgl/gpio.c:
https://review.coreboot.org/c/coreboot/+/60123/comment/74c3072c_578b19b7 PS11, Line 213: : PAD_CFG_NF(GPP_T2, DN_20K, DEEP, NF2), : PAD_CFG_NF(GPP_T3, DN_20K, DEEP, NF2), : PAD_NC(GPP_U4, NONE), : PAD_NC(GPP_U5, NONE), Where did they go? Seems they are disappeared? Please do such changes in a separate commit.
PS11: Add a short description what these columns mean. I suggest the format used in clevo/cml-u/variants/l140cu/gpio.c
https://review.coreboot.org/c/coreboot/+/60123/comment/9d3d0509_bc1bd4cd PS11, Line 34: /* A7 --[ GPP_A7 ]-- WLAN_PCM_CLK */ The first two columns seems redundant. What are these used for? I would remove them since the pad name is used in the macro.
https://review.coreboot.org/c/coreboot/+/60123/comment/e1520ca7_cecf54ba PS11, Line 60: /* A20 --[ GPP_A20 ]-- Not Connected */ If a pad is NC, then this is apparent through the PAD_NC macro. So I would just remove the comments for NC pins.
https://review.coreboot.org/c/coreboot/+/60123/comment/2e3edb23_9790426b PS11, Line 385: /* GPD0 --[ GPD0 ]-- PCH_BATLOW# */ : PAD_CFG_NF(GPD0, NONE, DEEP, NF1), : /* GPD1 --[ GPD1 ]-- AC_PRESENT */ : PAD_CFG_NF(GPD1, NONE, DEEP, NF1), : /* GPD2 --[ GPD2 ]-- LAN_WAKE# */ : PAD_NC(GPD2, NONE), : /* GPD3 --[ GPD3 ]-- SIO_PWRBTN# */ : PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), : /* GPD4 --[ GPD4 ]-- SIO_SLP_S3# */ : PAD_CFG_NF(GPD4, NONE, DEEP, NF1), : /* GPD5 --[ GPD5 ]-- SIO_SLP_S4# */ : PAD_CFG_NF(GPD5, NONE, DEEP, NF1), : /* GPD6 --[ GPD6 ]-- SIO_SLP_A# */ : PAD_CFG_NF(GPD6, NONE, DEEP, NF1), : /* GPD7 --[ GPD7 ]-- PCH_TBT_PERST# */ : PAD_CFG_GPO(GPD7, 0, PLTRST), : /* GPD8 --[ GPD8 ]-- SUSCLK */ : PAD_CFG_NF(GPD8, NONE, DEEP, NF1), : /* GPD9 --[ GPD9 ]-- SIO_SLP_WLAN# */ : PAD_CFG_NF(GPD9, NONE, DEEP, NF1), : /* GPD10--[ GPD10 ]-- SIO_SLP_S5# */ : PAD_CFG_NF(GPD10, NONE, DEEP, NF1), : /* GPD11--[ GPD11 ]-- PM_LANPHY_EN */ : PAD_CFG_NF(GPD11, NONE, DEEP, NF1), These were at the beginning before. Move them in a separate commit.
-
Felix Singer (Code Review)