Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Crystal Guo has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85124?usp=email )
Change subject: soc/mediatek/mt8196: Reserve DRAM buffers for HW TX TRACKING ......................................................................
Patch Set 18:
(8 comments)
File src/soc/mediatek/mt8196/dramc_info.c:
https://review.coreboot.org/c/coreboot/+/85124/comment/f355b6a8_8f8e1117?usp... : PS16, Line 29: BM_MEM_RESERVED);
move to the next line.
Done
File src/soc/mediatek/mt8196/dramc_info.c:
https://review.coreboot.org/c/coreboot/+/85124/comment/1e1cf91b_18c436fa?usp... : PS17, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
One blank line below.
Done
https://review.coreboot.org/c/coreboot/+/85124/comment/e3372246_2c13cfb5?usp... : PS17, Line 13: uint32_t
int
Done
https://review.coreboot.org/c/coreboot/+/85124/comment/cef2523d_26056214?usp... : PS17, Line 14: mc->num_entries / CHANNEL_MAX
Yes. […]
Done
https://review.coreboot.org/c/coreboot/+/85124/comment/a447885d_1d88d740?usp... : PS17, Line 15:
const
Done
https://review.coreboot.org/c/coreboot/+/85124/comment/f866483c_49089ebd?usp... : PS17, Line 23: const struct mem_chip_entry *e = &mc->entries[i];
`assert(e->rank < RANK_MAX)`
Done
https://review.coreboot.org/c/coreboot/+/85124/comment/d9f17048_78bd19c0?usp... : PS17, Line 24:
`* (e->channel_io_width / e->io_width)` […]
Done
https://review.coreboot.org/c/coreboot/+/85124/comment/b90bbe8c_d9439d87?usp... : PS17, Line 28: rank_size_sum += rank_size[i];
`assert(rank_size_sum >= reserved_size)`
Done