Attention is currently required from: Furquan Shaikh, Caveh Jalali, Paul Menzel, Tim Wawrzynczak.
Matthew Blecker has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56928 )
Change subject: mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56928/comment/2f231a04_8898f485
PS3, Line 9: Linux
Which Linux version did you test with?
4.4 and 5.4, I've updated the commit message.
https://review.coreboot.org/c/coreboot/+/56928/comment/7ce0fd09_f512b290
PS3, Line 16: Without this change, after rebinding the touchscreen's I2C adapter
: device using sysfs, the touchscreen ACPI and HID devices are absent, and
: the touchscreen is unresponsive.
Nit: I’d start the commit message body with the detailed problem description.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 4
Gerrit-Owner: Matthew Blecker
matthewb@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 12 Aug 2021 10:04:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment