Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove USB from trembyle overridetree ......................................................................
mb/google/zork: Remove USB from trembyle overridetree
This information is redundant since it's already specified in baseboard/devicetree_trembyle.cb
BUG=b:157580724 TEST=Boot, BT functional
Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/trembyle/overridetree.cb 1 file changed, 1 insertion(+), 71 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/43437/1
diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb index 22aced2..081471b 100644 --- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb +++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb @@ -43,77 +43,7 @@ device pci 1.6 off end # GPP Bridge 5 device pci 1.7 on end # GPP Bridge 6 - NVME device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on - chip drivers/usb/acpi - register "desc" = ""Root Hub"" - register "type" = "UPC_TYPE_HUB" - device usb 0.0 on - chip drivers/usb/acpi - register "desc" = ""Left Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(1, 1)" - device usb 2.0 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(1, 2)" - device usb 2.1 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(2, 1)" - device usb 2.2 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device usb 2.3 on end - end - chip drivers/usb/acpi - register "desc" = ""User-Facing Camera"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 2.4 on end - end - chip drivers/usb/acpi - register "desc" = ""Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 2.5 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(1, 1)" - device usb 3.0 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(1, 2)" - device usb 3.1 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(2, 1)" - device usb 3.2 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device usb 3.3 on end - end - chip drivers/usb/acpi - register "desc" = ""AR Camera"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 3.4 on end - end - end - end - end # USB 3.1 + device pci 0.3 on end # USB 3.1 device pci 0.4 on end # USB 3.1 end device pci 14.6 off end # Non-Functional SDHCI
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove USB from trembyle overridetree ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove USB from trembyle overridetree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43437/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/trembyle/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43437/1/src/mainboard/google/zork/v... PS1, Line 45: device pci 8.1 on You can actually drop this entire block from the overridetree.cb:
``` device pci 8.1 on # Internal GPP Bridge 0 to Bus A device pci 0.3 on end # USB 3.1 device pci 0.4 on end # USB 3.1 end ```
This is already done in baseboard devicetree.cb. So, it can be dropped from all variants.
Hello build bot (Jenkins), Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43437
to look at the new patch set (#3).
Change subject: mb/google/zork: Remove USB from trembyle overridetree ......................................................................
mb/google/zork: Remove USB from trembyle overridetree
This information is redundant since it's already specified in baseboard/devicetree_trembyle.cb or baseboard/devicetree_dalboz.cb
domain 0 is still required because sconfig uses it as an identity anchor to match devicetree and overridetree.
BUG=b:157580724 TEST=Boot zork, usb functional
Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb M src/mainboard/google/zork/variants/dalboz/overridetree.cb M src/mainboard/google/zork/variants/ezkinil/overridetree.cb M src/mainboard/google/zork/variants/morphius/overridetree.cb M src/mainboard/google/zork/variants/trembyle/overridetree.cb M src/mainboard/google/zork/variants/vilboz/overridetree.cb M src/mainboard/google/zork/variants/woomax/overridetree.cb 7 files changed, 0 insertions(+), 111 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/43437/3
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43437
to look at the new patch set (#4).
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
mb/google/zork: Remove redundant PCI info from overridetrees
This information is redundant since it's already specified in baseboard/devicetree_trembyle.cb or baseboard/devicetree_dalboz.cb
domain 0 is still required because sconfig uses it as an identity anchor to match devicetree and overridetree.
BUG=b:157580724 TEST=Boot zork, usb functional
Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb M src/mainboard/google/zork/variants/dalboz/overridetree.cb M src/mainboard/google/zork/variants/ezkinil/overridetree.cb M src/mainboard/google/zork/variants/morphius/overridetree.cb M src/mainboard/google/zork/variants/trembyle/overridetree.cb M src/mainboard/google/zork/variants/vilboz/overridetree.cb M src/mainboard/google/zork/variants/woomax/overridetree.cb 7 files changed, 0 insertions(+), 111 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/43437/4
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43437
to look at the new patch set (#5).
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
mb/google/zork: Remove redundant PCI info from overridetrees
This information is redundant since it's already specified in baseboard/devicetree_trembyle.cb or baseboard/devicetree_dalboz.cb
domain 0 is still required because sconfig uses it as an identity anchor to match devicetree and overridetree.
BUG=b:157580724 TEST=Boot zork, usb functional
Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb M src/mainboard/google/zork/variants/dalboz/overridetree.cb M src/mainboard/google/zork/variants/ezkinil/overridetree.cb M src/mainboard/google/zork/variants/morphius/overridetree.cb M src/mainboard/google/zork/variants/trembyle/overridetree.cb M src/mainboard/google/zork/variants/vilboz/overridetree.cb M src/mainboard/google/zork/variants/woomax/overridetree.cb 7 files changed, 0 insertions(+), 111 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/43437/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... PS5, Line 43: device pci 1.6 off end # GPP Bridge 5 : device pci 1.7 on end # GPP Bridge 6 - NVME You will have to now add this to devicetree_trembyle.cb:
``` device pci 1.6 off end # GPP Bridge 5 device pci 1.7 on end # GPP Bridge 6 - NVME device pci 14.6 off end # Non-Functional SDHCI ```
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... PS5, Line 43: device pci 1.6 off end # GPP Bridge 5 : device pci 1.7 on end # GPP Bridge 6 - NVME
You will have to now add this to devicetree_trembyle.cb: […]
Right. Are we sure dalboz shouldn't include this too?
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43437
to look at the new patch set (#6).
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
mb/google/zork: Remove redundant PCI info from overridetrees
This information is redundant since it's already specified in baseboard/devicetree_trembyle.cb or baseboard/devicetree_dalboz.cb
domain 0 is still required because sconfig uses it as an identity anchor to match devicetree and overridetree.
BUG=b:157580724 TEST=Boot zork, usb functional
Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb M src/mainboard/google/zork/variants/berknip/overridetree.cb M src/mainboard/google/zork/variants/dalboz/overridetree.cb M src/mainboard/google/zork/variants/ezkinil/overridetree.cb M src/mainboard/google/zork/variants/morphius/overridetree.cb M src/mainboard/google/zork/variants/trembyle/overridetree.cb M src/mainboard/google/zork/variants/vilboz/overridetree.cb M src/mainboard/google/zork/variants/woomax/overridetree.cb 8 files changed, 3 insertions(+), 111 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/43437/6
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
Patch Set 6: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... PS5, Line 43: device pci 1.6 off end # GPP Bridge 5 : device pci 1.7 on end # GPP Bridge 6 - NVME
Right. […]
As per PPR these devices don't exist on dalboz SoCs.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
Patch Set 6: Code-Review+2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v... PS5, Line 43: device pci 1.6 off end # GPP Bridge 5 : device pci 1.7 on end # GPP Bridge 6 - NVME
As per PPR these devices don't exist on dalboz SoCs.
Ack
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43437/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/trembyle/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43437/1/src/mainboard/google/zork/v... PS1, Line 45: device pci 8.1 on
You can actually drop this entire block from the overridetree.cb: […]
Done
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees ......................................................................
mb/google/zork: Remove redundant PCI info from overridetrees
This information is redundant since it's already specified in baseboard/devicetree_trembyle.cb or baseboard/devicetree_dalboz.cb
domain 0 is still required because sconfig uses it as an identity anchor to match devicetree and overridetree.
BUG=b:157580724 TEST=Boot zork, usb functional
Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43437 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb M src/mainboard/google/zork/variants/berknip/overridetree.cb M src/mainboard/google/zork/variants/dalboz/overridetree.cb M src/mainboard/google/zork/variants/ezkinil/overridetree.cb M src/mainboard/google/zork/variants/morphius/overridetree.cb M src/mainboard/google/zork/variants/trembyle/overridetree.cb M src/mainboard/google/zork/variants/vilboz/overridetree.cb M src/mainboard/google/zork/variants/woomax/overridetree.cb 8 files changed, 3 insertions(+), 111 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index ec7a706..585f5a7 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -201,6 +201,8 @@ device pci 1.3 on end # GPP Bridge 2 - SD device pci 1.4 off end # GPP Bridge 3 device pci 1.5 off end # GPP Bridge 4 + device pci 1.6 off end # GPP Bridge 5 + device pci 1.7 on end # GPP Bridge 6 - NVME device pci 8.0 on end # Dummy Host Bridge, must be enabled device pci 8.1 on # Internal GPP Bridge 0 to Bus A device pci 0.0 on end # Internal GPU @@ -340,6 +342,7 @@ end end end + device pci 14.6 off end # Non-Functional SDHCI device pci 18.0 on end # Data fabric [0-7] device pci 18.1 on end device pci 18.2 on end diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index 229469e..b4d4fa4 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -40,13 +40,6 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit - device pci 1.6 off end # GPP Bridge 5 - device pci 1.7 on end # GPP Bridge 6 - NVME - device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on end # USB 3.1 - device pci 0.4 on end # USB 3.1 - end - device pci 14.6 off end # Non-Functional SDHCI end # domain
device mmio 0xfedc4000 on diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb index 81fc4fd..16a6e44 100644 --- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb @@ -40,9 +40,6 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit - device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on end # USB 3.1 - end end # domain
device mmio 0xfedc4000 on # APU_I2C2_BASE diff --git a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb index f7366ac..abdc397 100644 --- a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb +++ b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb @@ -42,13 +42,6 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit - device pci 1.6 off end # GPP Bridge 5 - device pci 1.7 on end # GPP Bridge 6 - NVME - device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on end # USB 3.1 - device pci 0.4 on end # USB 3.1 - end - device pci 14.6 off end # Non-Functional SDHCI end # domain
device mmio 0xfedc4000 on diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb index 1240aa6..c0de2ce 100644 --- a/src/mainboard/google/zork/variants/morphius/overridetree.cb +++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb @@ -40,13 +40,6 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit - device pci 1.6 off end # GPP Bridge 5 - device pci 1.7 on end # GPP Bridge 6 - NVME - device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on end # USB 3.1 - device pci 0.4 on end # USB 3.1 - end - device pci 14.6 off end # Non-Functional SDHCI end # domain
device mmio 0xfedc4000 on diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb index 22aced2..d66e518 100644 --- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb +++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb @@ -40,83 +40,6 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit - device pci 1.6 off end # GPP Bridge 5 - device pci 1.7 on end # GPP Bridge 6 - NVME - device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on - chip drivers/usb/acpi - register "desc" = ""Root Hub"" - register "type" = "UPC_TYPE_HUB" - device usb 0.0 on - chip drivers/usb/acpi - register "desc" = ""Left Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(1, 1)" - device usb 2.0 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(1, 2)" - device usb 2.1 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(2, 1)" - device usb 2.2 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device usb 2.3 on end - end - chip drivers/usb/acpi - register "desc" = ""User-Facing Camera"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 2.4 on end - end - chip drivers/usb/acpi - register "desc" = ""Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 2.5 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(1, 1)" - device usb 3.0 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(1, 2)" - device usb 3.1 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(2, 1)" - device usb 3.2 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device usb 3.3 on end - end - chip drivers/usb/acpi - register "desc" = ""AR Camera"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 3.4 on end - end - end - end - end # USB 3.1 - device pci 0.4 on end # USB 3.1 - end - device pci 14.6 off end # Non-Functional SDHCI end # domain
device mmio 0xfedc4000 on diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index 79f26f2..d3e01e2 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -36,9 +36,6 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit - device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on end # USB 3.1 - end device pci 14.3 on # - D14F3 bridge chip ec/google/chromeec device pnp 0c09.0 on diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index 7b58df1..077e983 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -41,13 +41,6 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit - device pci 1.6 off end # GPP Bridge 5 - device pci 1.7 on end # GPP Bridge 6 - NVME - device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on end # USB 3.1 - device pci 0.4 on end # USB 3.1 - end - device pci 14.6 off end # Non-Functional SDHCI end # domain
device mmio 0xfedc4000 on end
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)
-
Rob Barnes (Code Review)