Attention is currently required from: Maulik V Vaghela, Sridhar Siricilla, Nick Vaccaro, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63552 )
Change subject: mb/google/brya: Reset XHCI controller while preparing for S5
......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63552/comment/af74f763_53043c45
PS3, Line 13: resume
`poweron`
Ack
https://review.coreboot.org/c/coreboot/+/63552/comment/1e2eec03_a6a4ed6d
PS3, Line 15: resume
`poweron`
Ack
https://review.coreboot.org/c/coreboot/+/63552/comment/c8877b8b_e336e486
PS3, Line 31: resuming
`powering on`
Ack
https://review.coreboot.org/c/coreboot/+/63552/comment/fbf2ea21_d5fe5b66
PS3, Line 33: Upon resume
`During poweron`
Ack
https://review.coreboot.org/c/coreboot/+/63552/comment/19c6268f_ef81b0b8
PS3, Line 35: PMC tries to send the IPC command, finally, results into timeout.
`which results in a timeout. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf06a64f055a0cee3659b410652082f31e18e149
Gerrit-Change-Number: 63552
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 21:24:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment