Attention is currently required from: Sunwei Li, Henry Sun, Paul Menzel, Zhi7 Li, Karthik Ramasubramanian.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56973 )
Change subject: mb/google/dedede/var/cappy2: Fix the DUT with cirrus codec PLT fail
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56973/comment/f0ac0861_a424c3c3
PS2, Line 8:
As Paul mentioned please explain what the failure is, why the failure is observed with the existing […]
irq -> ACPI_DESCRIPTOR_INTERRUPT -> IO-APIC will assert interrupt frequently;
irq_gpio -> ACPI_DESCRIPTOR_GPIO -> INT34C8 is normal;
I think that because can't set both EDGE for IRQ configuration:
/* ACPI 6.1 section 6.4.3.6: Extended Interrupt Descriptor */
void acpi_device_write_interrupt(const struct acpi_irq *irq)
{
...
/* This is supported by GpioInt() but not Interrupt() */
if (irq->polarity == ACPI_IRQ_ACTIVE_BOTH)
return;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56973
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65bca519f75af84848284f039b6ad67cb1887823
Gerrit-Change-Number: 56973
Gerrit-PatchSet: 2
Gerrit-Owner: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-CC: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Attention: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sat, 14 Aug 2021 11:58:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment