Attention is currently required from: Maxim.
Felix Singer has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83107?usp=email )
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard ......................................................................
Patch Set 16:
(5 comments)
File src/mainboard/asrock/imb-1222/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83107/comment/68a7cb75_92b1cd8f?usp... : PS16, Line 6: .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, This is the default. Please remove.
https://review.coreboot.org/c/coreboot/+/83107/comment/e2ea0a8b_87dd154a?usp... : PS16, Line 45: device cpu_cluster 0 on end Already in chipset devicetree. Please remove.
https://review.coreboot.org/c/coreboot/+/83107/comment/a519c43d_dcc0dffe?usp... : PS16, Line 91: device ref heci1 on end Same as in chipset devicetree, please remove.
https://review.coreboot.org/c/coreboot/+/83107/comment/5ff510e1_c0ea3988?usp... : PS16, Line 143: device ref fast_spi on end Same as in chipset devicetree, please remove.
File src/mainboard/asrock/imb-1222/fmap.fmd:
PS16: Is there a reason for the custom fmap? It looks pretty much like a standard one.