Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61174 )
Change subject: mb/google/guybrush/var/dewatt: Update touchpad GPIO configuration
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/61174/comment/ed57d963_4f6278b0
PS2, Line 43: LEVEL_LOW
Probing may take too long and slow down boot time. […]
FW_CONFIG probe is pretty much free isn't it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61174
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29734595d37283adc6fd4a0ed17f51a5c9061796
Gerrit-Change-Number: 61174
Gerrit-PatchSet: 5
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:53:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Bhanu Prakash Maiya
bhanumaiya@google.com
Comment-In-Reply-To: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment