Change in coreboot[master]: [WIP] mb/google,intel: Split chromeos.c files - coreboot-gerrit

8 Nov 2021


      Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59018 )
Change subject: [WIP] mb/google,intel: Split chromeos.c files
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/intel/kblrvp/bootmode.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132596):
https://review.coreboot.org/c/coreboot/+/59018/comment/fb238ac8_5873983f 
PS2, Line 21: 		if (google_chromeec_get_switches() &
suspect code indent for conditional statements (16, 16)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59018
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4ccd31edc5ab6c4bc7890a8de1ae270141d18a7
Gerrit-Change-Number: 59018
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 08 Nov 2021 18:05:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment