Attention is currently required from: Bernardo Perez Priego. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58215 )
Change subject: util/cse_serger: Add command `create-cse-region` ......................................................................
Patch Set 3:
(2 comments)
File util/cbfstool/cse_serger.c:
https://review.coreboot.org/c/coreboot/+/58215/comment/1d84d2b2_ec3a6fe6 PS3, Line 720: if (i == 0) {
braces {} are not necessary for any arm of this statement […]
It is a little weird. If I remove the braces {}, then I also have to drop the ';' at the end because of the way ERROR is defined. I have done that in latest patchset. Let me know what you think.
https://review.coreboot.org/c/coreboot/+/58215/comment/827d0646_71a7bbda PS3, Line 733: memcpy(buffer_get(&wbuff), buffer_get(&rbuff), buffer_size(&rbuff));
should the size of wbuff be verified?
Done