[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add SPM loader - coreboot-gerrit

20 Dec 2024


      Attention is currently required from: Alicja Michalska, Ccong Chen, Hung-Te Lin, Jarried Lin, Wenzhen Yu.
Yu-Ping Wu has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add SPM loader
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
File src/soc/mediatek/mt8196/include/soc/spm.h:
https://review.coreboot.org/c/coreboot/+/85599/comment/0a14e291_8f4cc949?usp... :
PS14, Line 1133: check_member(mtk_spm_regs, spm_twam_timer_out, 0xFFC);
Add `check_member(mtk_spm_regs, md1_pwr_con, 0xE00);` (for CB:85651)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie09346f46cb734c74776b760485e7f35d4357e5e
Gerrit-Change-Number: 85599
Gerrit-PatchSet: 14
Gerrit-Owner: Ccong Chen ot_ccong.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Wenzhen Yu wenzhen.yu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alicja Michalska ahplka19@gmail.com
Gerrit-CC: Jarried Lin jarried.lin@mediatek.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Wenzhen Yu wenzhen.yu@mediatek.corp-partner.google.com
Gerrit-Attention: Alicja Michalska ahplka19@gmail.com
Gerrit-Attention: Ccong Chen ot_ccong.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 20 Dec 2024 06:14:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes